SFX overhaul: real generated audio for the 12 silenced effects - #261
Merged
Conversation
Regenerate explosion, wall break, pickup and all nine powerup pickup cues with Stable Audio Open via the assetfactory MCP (cartoonish one-shots, 1.0-2.0 s, trimmed + faded, 25 Hz highpass, peak-matched to fire.ogg, OGG Vorbis q5). Rewire SfxFiles so every SfxKind maps to a real clip, drop the silent-placeholder path, and add SfxPool.HasStream so the tests can assert every kind decodes a real stream in-engine. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Vodkadav
pushed a commit
that referenced
this pull request
Jul 17, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Vodkadav
added a commit
that referenced
this pull request
Jul 17, 2026
* PROGRESS: record 2026-07-17 parallel batch (SFX overhaul, net victory screen, net teleport pads, perf check) Three branches pushed pending owner merge + SFX ear-check; perf verdict recorded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * PROGRESS: cite PRs #261/#262 for the 2026-07-17 batch Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Daniel Machado <au280502@uni.au.dk> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deliberately-silenced placeholder SFX (tank-death explosion, wall break, generic pickup, all 9 per-powerup cues) with locally-generated Stable Audio clips (assetfactory MCP, CLAP-ranked best-of-N, ffmpeg trim/fade/highpass, peak-matched to fire.ogg). Every
SfxKindis now mapped inSfxPool; the silent-placeholder path is gone.EveryKind_ResolvesALoadedStreamdecodes all 20 clips in-engine (catches any non-vorbis regression)docs/credits/assets.mdOwner ear-check pending — clip quality is the one ungated review left; if any clip sounds off it can be regenerated individually.
🤖 Generated with Claude Code